Refine poster/talk preview card thumbnail (#840 follow-up)#1378
Merged
Conversation
) Polish follow-up to the #840 preview card, refining how the thumbnail is framed and sized: - Rounded-rect + subtle 1px outline so the thumbnail reads as a framed preview (using the --border-radius-md / --color-border tokens). - Height-capped instead of width-driven, so portrait posters stay compact rather than running tall; landscape posters still fill the card width. - File size now sits next to its label instead of floating to the trailing edge, so a lone action (PDF only) no longer leaves an awkward gap. - The card hugs its image: thumbnailPreview.js sizes the image to a fixed 260x240 box (aspect preserved) so it has a definite width, and the card shrink-wraps it. This also resets the global base.css `.popover { width: 50vw; min-width: 300px }` on the preview card, which was pinning it ~300px wide and leaving whitespace beside portrait thumbnails. Scoped to .artifact-preview-* so the Cite popover is unaffected. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Member
Author
|
Here's the two poster types. Portrait
Landscape
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small visual polish follow-up to the #840 preview card (which shipped in 2.18.0), based on testing against real portrait and landscape posters.
Changes
--border-radius-md/--color-border), so it reads as a framed preview.thumbnailPreview.jsnow sizes the image to a fixed 260×240 box (aspect preserved) so it has a definite width, and the card shrink-wraps it. This also resets the globalbase.css.popover { width: 50vw; min-width: 300px }on the preview card, which was pinning it ~300px wide and leaving whitespace beside portrait thumbnails.All scoped to
.artifact-preview-*, so the Cite popover is unaffected.Testing
Verified locally against a portrait poster (StreetReaderAI ASSETS 2025) and a landscape poster — both now hug the thumbnail with no side whitespace, sizes group cleanly with their labels.
CSS/JS only; no template, model, or test changes.
🤖 Generated with Claude Code